[do not merge] temporarily disable network isolation#3416
Open
wonwuakpa-msft wants to merge 1 commit intomainfrom
Open
[do not merge] temporarily disable network isolation#3416wonwuakpa-msft wants to merge 1 commit intomainfrom
wonwuakpa-msft wants to merge 1 commit intomainfrom
Conversation
wonwuakpa-msft
requested review from
adreed-msft,
dphulkar-msft,
gapra-msft,
seanmcc-msft and
vibhansa-msft
as code owners
wonwuakpa-msft
requested review from
shnayak-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily disables 1ES pipeline network isolation injection to unblock git fetch from github.com during the release build.
Changes:
- Adds a 1ES pipeline template
featureFlagsoverride to disable network isolation in the official pipeline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+65
| featureFlags: | ||
| disableNetworkIsolation: true |
wonwuakpa-msft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporarily disabled network isolation injection because it was wrongly blocking github.com. This caused git fetch to fail and preventing our 10.32.2 release. You can see the failing step here
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Fix was to temporarily disable network isolation till the team can identify why github.com is being blocked.
Related Links:
[Email Subject: ]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!